add enabled property to lint options #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadkahelghi-grabtaxi
requested review from
minkuanlim-grabtaxi,
vanminh-grabtaxi,
arunsampathkumar-grabtaxi,
stevenchao-grabtaxi,
arnav-grabtaxi and
adarsh-grabtaxi
as code owners
mohammadkahelghi-grabtaxi
force-pushed
the
add-lint-enabled-property
branch
3 times, most recently
from
7cb7bb8
to
1f6cf44
Compare
arunkumar9t2
approved these changes
Mar 11, 2024
| @@ -167,6 +167,9 @@ private fun lintConfigs( | |||
| lintOptions: LintOptions, | |||
| project: Project | |||
| ): LintConfigs { | |||
| // enable lint for all targets by default | |||
| val enabled = true | |||
There was a problem hiding this comment.
Later we can infer this from project.plugins.hasPlugin("com.android.lin")
arunsampathkumar-grabtaxi
approved these changes
Mar 11, 2024
mohammadkahelghi-grabtaxi
force-pushed
the
add-lint-enabled-property
branch
from
1f6cf44
to
c860015
Compare
mohammadkahelghi-grabtaxi
force-pushed
the
add-lint-enabled-property
branch
from
c860015
to
e05e0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add enabled property to lint options